Skip to content

🧹 [code health] Remove legacy fallback logic for clipboard extension - #10

Closed
Dor-bl wants to merge 3 commits into
masterfrom
refactor-remove-clipboard-fallback-13004971608429350481
Closed

🧹 [code health] Remove legacy fallback logic for clipboard extension#10
Dor-bl wants to merge 3 commits into
masterfrom
refactor-remove-clipboard-fallback-13004971608429350481

Conversation

@Dor-bl

@Dor-bl Dor-bl commented Aug 10, 2026

Copy link
Copy Markdown
Owner

🎯 What: Removed the fallback logic for missing clipboard Appium extensions in appium/webdriver/extensions/clipboard.py and deleted associated legacy constants (GET_CLIPBOARD, SET_CLIPBOARD).

💡 Why: Simplifies the logic and improves maintainability by eliminating fallback checks and usage of deprecated legacy endpoints, conforming the extension to purely use the execute_script('mobile: ...') pattern. This also cleans up dead code from the unit tests.

Verification: Ran the specific unit tests (test/unit/webdriver/device/clipboard_test.py) as well as the entire test suite via make unittest. All tests passed.

Result: A cleaner implementation of the Clipboard extension with less dependency on outdated legacy paths and fewer unused imports/mixins.


PR created automatically by Jules for task 13004971608429350481 started by @Dor-bl

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Dor-bl Dor-bl closed this Aug 10, 2026

Dor-bl commented Aug 10, 2026

Copy link
Copy Markdown
Owner Author

Closing — no longer relevant against upstream (appium/python-client). Current upstream appium/webdriver/extensions/clipboard.py already has zero UnknownMethodException/CanRememberExtensionPresence fallback logic — it already matches this PR's target state exactly. This was covered by upstream's legacy-fallback removal effort (#1267).


Generated by Claude Code

@google-labs-jules

Copy link
Copy Markdown

Closing — no longer relevant against upstream (appium/python-client). Current upstream appium/webdriver/extensions/clipboard.py already has zero UnknownMethodException/CanRememberExtensionPresence fallback logic — it already matches this PR's target state exactly. This was covered by upstream's legacy-fallback removal effort (#1267).


Generated by Claude Code

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant